EnumMode enum option #2993
Merged
EnumMode enum option #2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
commented
Jun 17, 2024
Comment on lines
+47
to
+55
| /** | ||
| * Defines how an enum type is to be generated. This is only supported by Kotlin generation. | ||
| * - 'enum_class': the enum type will be generated as a Kotlin enum class. | ||
| * - 'sealed_class': the enum type will be generated as a Kotlin sealed class. | ||
| * | ||
| * When set, the value of this option takes precedence over the global enum mode that may be set | ||
| * at the Kotlin target level in the Wire Gradle plugin. | ||
| */ | ||
| optional string enum_mode = 1190; |
There was a problem hiding this comment.
even though enum_class and sealed_class are Kotlin words, I think we'd wanna use this option on Java generation as well later, even if they are less explicit.
Hence the option name to enum_mode instead of something like kotlin_enum
swankjesse
reviewed
Jun 17, 2024
|
|
||
| // Target is set to "enum_class" so the option should not have any effect. | ||
| enum Period { | ||
| option (wire.enum_mode) = "enum_class"; |
swankjesse
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes precedence over the newly created
KotlinTarget#enumModeto allow granular migration.Extension registered here protocolbuffers/protobuf#17158