Allow removing followers and fix follow rejections #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds the ability to remove a user from your followers list * fixes verbs.Reject to process reject activities for previously accepted follows in both directions fixes bookwyrm-social#2635
|
@bookwyrm-social/code-review this can be checked with a Mastodon account, but I probably should add one or two tests? |
dato
reviewed
Nov 20, 2023
- rationalise activitypub.Reject and fix model being undefined - fix not being able to follow users from followers page: 'delete' option now in user_options dropdown - revert bookwyrm.js - fix delete_follow_request deleting instead of rejecting - add user id to 'remove-follow' path
|
@dato better? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verbs.Rejectto process "reject" activities for previously accepted follows in both directionsTo explain the second point - previously when e.g. a Mastodon user deleted a follow by a BookWyrm user, BookWyrm errored out when received the
rejectactivity so the Mastodon user was still listed in "following". This PR fixes this so that users are removed from the "followers" list of the user deleting the follow, and also deleted from the "following" list of the target user.fixes #2635